Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with markup rendering in version 0.2.9 #119

Closed
helenb opened this issue Jul 31, 2020 · 1 comment · Fixed by #124
Closed

Bug with markup rendering in version 0.2.9 #119

helenb opened this issue Jul 31, 2020 · 1 comment · Fixed by #124
Assignees
Labels
bug Something isn't working
Milestone

Comments

@helenb
Copy link
Member

helenb commented Jul 31, 2020

Found a bug? Please fill out the sections below. 👍

Issue Summary

Upgrading the pattern library from 0.2.8 to 0.2.9 caused markup rendering inside the pattern library to break. Viewing an identical page without the pattern library did not cause any issues.

Steps to Reproduce

For Ben's benefit, this can be tested on the GOSH repo on Torchbox's gitlab.

  1. Set up a local build using the main branch
  2. Update the configuration so the pattern library is at version 0.2.9
  3. View the home page in the pattern library and compare the markup to the home page viewed without the pattern library
  4. Downgrade to 0.2.8 and compare.
@bcdickinson
Copy link

This appears to be related to broken detection of "page" templates that don't need wrapping in the base template: a8f79ed#diff-8137058159488acb9fbce2f9ec4f9c9bL79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants