Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No regularization term for Rescal #179

Open
phucdoitoan opened this issue Aug 21, 2020 · 4 comments
Open

No regularization term for Rescal #179

phucdoitoan opened this issue Aug 21, 2020 · 4 comments
Labels
help wanted Extra attention is needed invalid This doesn't seem right

Comments

@phucdoitoan
Copy link

phucdoitoan commented Aug 21, 2020

  • TorchKGE version: 0.6.13

I read the source code of RESCALModel but I realize that there is no regularization term as opppose to the original Rescal paper of Nickel?
Can somebody explain why torchkge does not use regularization term?

@armand33
Copy link
Member

Hi @phucdoitoan, thanks for pointing that out. The regularization term is indeed missing and should be added. Feel free to submit a merge request if you have time to contribute on this issue.

@MacOS
Copy link

MacOS commented Mar 3, 2021

Has this already been addressed? If not, I would be willing to fix this.

@armand33
Copy link
Member

armand33 commented Mar 4, 2021

Has this already been addressed? If not, I would be willing to fix this.

Hi, this has not been addressed. Feel free to contribute ! Thanks

@armand33 armand33 added the invalid This doesn't seem right label May 25, 2021
@armand33 armand33 added the help wanted Extra attention is needed label Jul 29, 2021
@shreyash-Pandey-Katni
Copy link
Contributor

Hello @armand33 , I checked into the original research paper and found out the following things:

  1. regularization term is just coined and not used further in the research paper.
  2. this term is used as a constraint in the following research paper for comparison purposes: A latent factor model for highly multi-relational data
    Let me know your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

4 participants