on_finish() not called after max body size hit

[dylanbfox]

I override self.request.connection.set_max_body_size(XXXXXX) and set it to some value, say 5MB. I also depend on on_finish() to do some cleanup once the request finishes. If the connection is closed with the client because the body size limit is hit, on_finish does not get called.

[ploxiln]

I think you could check for missed cleanup in on_connection_close()

I'm not completely sure if the fact that on_finish() may not be called after prepare() is called is a bug ... might this only be possible for @stream_request_body?

[dylanbfox]

Correct -- this is with @stream_request_body

Is the expected behavior that on_finish() is also not called if the client abruptly closes the connection? I think I'm seeing that as well (also with @stream_request_body)

Update:

Just tested this and on_connection_close() is called if either the server or client close the connection. Thanks for the help!

Is it safe to assume that on_connection_close() and on_finish() won't ever both be called for the same request?

[bdarnell]

Yes, I think that's right. If prepare is called, you'll get exactly one call to either on_connection_close or on_finish.