-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename fields in upload torrent response to match latest changes in the database #283
Closed
Tracked by
#275
Labels
Milestone
Comments
da2ce7
added
Code Cleanup / Refactoring
Tidying and Making Neat
and removed
tidying
labels
Oct 12, 2023
I would be happy to take this task. @josecelano |
hi @alexohneander, cool! |
Hi, @alexohneander I'm assigning this issue to myself because I have finished all the other issues related to this one and I also wan tot finish this to close the epic. |
Changes made in the frontend: torrust/torrust-index-api-lib#43 |
Relates to: torrust/torrust-index-gui#279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Parent issue: #275
After successfully uploading a torrent you get a response like this:
We decided to change the infohashes table to:
Where
info_hash
is the original info-hash (from the uploaded torrent file) andcanonical_info_hash
is the one we use to refer to the uploaded torrent (without non-standardinfo
dict fields).I think we should also rename the fields in this response:
The problem is we use the name
info_hash
in thetorrust_torrents::info_hash
, and renaming that field would require changes in many queries.What do you think @da2ce7?
The text was updated successfully, but these errors were encountered: