refactor: [#116] improve structured logging with consistent status field

- Add 'status' field to all detector log entries (installed/not installed)
- Move error handling from main() into app::run() using tracing::error!
- Change app::run() return type from Result<(), AppError> to ExitCode
- Simplify main() binary to just call app::run() and exit
- Update tests to verify exit codes only (no output with --log-level off)
- Makes logging output easily parsable by automation tools

Author: josecelano

packages/dependency-installer/src/app.rs

@@ -101,13 +101,9 @@ impl From<ListError> for AppError {
 
 /// Run the CLI application
 ///
-/// # Errors
-///
-/// Returns an error if:
-/// - Dependencies are missing
-/// - Invalid tool name is provided
-/// - Internal error occurs during dependency checking
-pub fn run() -> Result<(), AppError> {
+/// Returns the appropriate exit code based on the operation result.
+/// Errors are logged using tracing and do not propagate to stderr.
+pub fn run() -> ExitCode {
     let cli = Cli::parse();
 
     // Determine log level: verbose flag overrides log-level argument
@@ -122,12 +118,19 @@ pub fn run() -> Result<(), AppError> {
 
     let manager = DependencyManager::new();
 
-    match cli.command {
+    let result: Result<(), AppError> = match cli.command {
         Commands::Check { dependency } => {
-            crate::handlers::check::handle_check(&manager, dependency)?;
+            crate::handlers::check::handle_check(&manager, dependency).map_err(AppError::from)
         }
-        Commands::List => crate::handlers::list::handle_list(&manager)?,
-    }
+        Commands::List => crate::handlers::list::handle_list(&manager).map_err(AppError::from),
+    };
 
-    Ok(())
+    match result {
+        Ok(()) => ExitCode::Success,
+        Err(e) => {
+            // Log the error using tracing instead of eprintln
+            tracing::error!(error = %e, "Command failed");
+            e.to_exit_code()
+        }
+    }
 }

packages/dependency-installer/src/bin/dependency-installer.rs

@@ -12,16 +12,9 @@
 
 use std::process;
 
-use torrust_dependency_installer::app::{self, ExitCode};
+use torrust_dependency_installer::app;
 
 fn main() {
-    let exit_code = match app::run() {
-        Ok(()) => ExitCode::Success,
-        Err(e) => {
-            eprintln!("Error: {e}");
-            e.to_exit_code()
-        }
-    };
-
+    let exit_code = app::run();
     process::exit(exit_code.into());
 }

packages/dependency-installer/src/detector/ansible.rs

@@ -22,9 +22,17 @@ impl DependencyDetector for AnsibleDetector {
         })?;
 
         if installed {
-            info!(dependency = "ansible", "Ansible is installed");
+            info!(
+                dependency = "ansible",
+                status = "installed",
+                "Ansible is installed"
+            );
         } else {
-            info!(dependency = "ansible", "Ansible is not installed");
+            info!(
+                dependency = "ansible",
+                status = "not installed",
+                "Ansible is not installed"
+            );
         }
 
         Ok(installed)

packages/dependency-installer/src/detector/cargo_machete.rs

@@ -26,10 +26,15 @@ impl DependencyDetector for CargoMacheteDetector {
             })?;
 
         if installed {
-            info!(dependency = "cargo-machete", "cargo-machete is installed");
+            info!(
+                dependency = "cargo-machete",
+                status = "installed",
+                "cargo-machete is installed"
+            );
         } else {
             info!(
                 dependency = "cargo-machete",
+                status = "not installed",
                 "cargo-machete is not installed"
             );
         }

packages/dependency-installer/src/detector/lxd.rs

@@ -23,9 +23,13 @@ impl DependencyDetector for LxdDetector {
         })?;
 
         if installed {
-            info!(dependency = "lxd", "LXD is installed");
+            info!(dependency = "lxd", status = "installed", "LXD is installed");
         } else {
-            info!(dependency = "lxd", "LXD is not installed");
+            info!(
+                dependency = "lxd",
+                status = "not installed",
+                "LXD is not installed"
+            );
         }
 
         Ok(installed)

packages/dependency-installer/src/detector/opentofu.rs

@@ -22,9 +22,17 @@ impl DependencyDetector for OpenTofuDetector {
         })?;
 
         if installed {
-            info!(dependency = "opentofu", "OpenTofu is installed");
+            info!(
+                dependency = "opentofu",
+                status = "installed",
+                "OpenTofu is installed"
+            );
         } else {
-            info!(dependency = "opentofu", "OpenTofu is not installed");
+            info!(
+                dependency = "opentofu",
+                status = "not installed",
+                "OpenTofu is not installed"
+            );
         }
 
         Ok(installed)

packages/dependency-installer/tests/docker_check_command.rs

@@ -18,17 +18,9 @@ async fn test_check_all_reports_missing_dependencies() {
     // Start Ubuntu container with the binary
     let container = UbuntuContainerBuilder::new(&binary_path).start().await;
 
-    // Run the check command with logging disabled for clean test output
-    let output = container.exec(&["dependency-installer", "check", "--log-level", "off"]);
-
-    // Verify it reports missing dependencies in the error message
-    assert!(
-        output.contains("Missing 4 out of 4 required dependencies"),
-        "Expected missing dependencies error message, got: {output}"
-    );
-
-    // Verify exit code is non-zero (failure)
-    let exit_code = container.exec_with_exit_code(&["dependency-installer", "check", "--log-level", "off"]);
+    // Verify exit code is non-zero (failure) when dependencies are missing
+    let exit_code =
+        container.exec_with_exit_code(&["dependency-installer", "check", "--log-level", "off"]);
     assert_eq!(
         exit_code, 1,
         "check command should exit with 1 when dependencies missing"
@@ -42,15 +34,7 @@ async fn test_check_specific_dependency() {
 
     let container = UbuntuContainerBuilder::new(&binary_path).start().await;
 
-    // Run check command for opentofu (which is not installed) with logging disabled
-    let output = container.exec(&["dependency-installer", "check", "--dependency", "opentofu", "--log-level", "off"]);
-
-    // Verify it reports missing dependency in the error message
-    assert!(
-        output.contains("opentofu: not installed"),
-        "Expected opentofu missing error message, got: {output}"
-    );
-
+    // Verify exit code when checking missing specific dependency
     let exit_code = container.exec_with_exit_code(&[
         "dependency-installer",
         "check",