Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"is-stream" is an ESM package and cannot be used in the .cjs bundle #31

Closed
monsonjeremy opened this issue Feb 28, 2022 · 5 comments
Closed

"is-stream" is an ESM package and cannot be used in the .cjs bundle #31

monsonjeremy opened this issue Feb 28, 2022 · 5 comments

Comments

@monsonjeremy
Copy link

is-stream version 3.0.0 is an ESM only package, therefore when used in the CJS bundle untranspiled it causes errors in webpack/next-js/etc... This library should likely use ^2.0.0 or ship only a .esm bundle.
@metallicalfa2
Copy link
Contributor

@ieow

@ieow
Copy link
Collaborator

ieow commented Mar 1, 2022

@monsonjeremy is right.
downgrade is-stream to ^2.0.0

@ieow ieow mentioned this issue Mar 1, 2022
Merged
@monsonjeremy monsonjeremy mentioned this issue Mar 2, 2022
Open
1 task
@pgarciaegido
Copy link

Hey guys,

When are you guys releasing the fix for this? Any way we can overcome this without a release from you guys?

Thanks a lot!!!

@ieow
Copy link
Collaborator

ieow commented Mar 24, 2022 •
edited
Loading

I think the better way to load embed is using dynamic loading.

check this PR
solana-labs/dapp-scaffold#154

@ieow
Copy link
Collaborator

ieow commented Jun 8, 2022

#32 is merged

@ieow ieow closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ieow @monsonjeremy @metallicalfa2 @pgarciaegido