Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarification with cocoapods #12

Closed
johndpope opened this issue May 12, 2017 · 8 comments
Closed

clarification with cocoapods #12

johndpope opened this issue May 12, 2017 · 8 comments

Comments

@johndpope
Copy link

johndpope commented May 12, 2017

I run the xcconfig-extractor and it successfully rips out settings to Configuration folder.

It seems that cocoapods overrides all configs with it's own files.
Perhaps need to have cocoapods optionally adopt this library to strip out settings.
Is there any way to have the new config files piggy back off the pod settings? (inherit from)
screen shot 2017-05-12 at 9 45 18 am

@toshi0383
Copy link
Owner

Hi @johndpope ,
By default --include-existing option is enabled, so if you have existing xcconfigs configured on Xcode, then you should see #include lines in generated xcconfigs. You just need to simply add generated xcconfigs to your project, and replace the Configurations manually.
Please follow README for Build Settings Validation.

In my case I had CocoaPods' xcconfigs setup as well, and it has been working fine after applying xcconfig-extractor.👌
Let me know if you encountered any issues related to CocoaPods. I'd be happy to dig into it.

@johndpope
Copy link
Author

I'll have another crack thanks. Did you run pod update ? I worry it will be hard to maintain. I know the dudes at artsy and think this code is fantastic and worth considering to merge into cocoa pods.

@toshi0383
Copy link
Owner

toshi0383 commented May 16, 2017

@johndpope
pod update preserves existing xcconfig, so I'd say it would be easy to maintain.😉

@toshi0383
Copy link
Owner

By the way I'm working on pbxproj parser right now, so adding xcconfig to xcodeproj will be handled automatically in near future.

@toshi0383
Copy link
Owner

adding xcconfig to xcodeproj will be handled automatically in near future

Done in #13 .

@toshi0383
Copy link
Owner

Closing this.
Please feel free to reopen this issue anytime. 😉

@johndpope
Copy link
Author

nice.

@johndpope
Copy link
Author

https://github.com/johndpope/xcodeproj FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants