Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark and Optimize Saturation Class #52

Open
JoseDiazRohena opened this issue Apr 16, 2023 · 0 comments
Open

Benchmark and Optimize Saturation Class #52

JoseDiazRohena opened this issue Apr 16, 2023 · 0 comments
Milestone
v1.0.0

Comments

@JoseDiazRohena
Copy link
Contributor

JoseDiazRohena commented Apr 16, 2023 •
edited
Loading

Our Saturation class wasn't really implemented with performance in mind.
So the class should be benchmarked and optimized.

Preconditions

Suggestions

  • Template the class to minimize branching in per-sample loops
  • Rearrange the block processing loops so we iterate channel, samples.
  • Calculate gain values for negative and positive input (asymmetry) when the parameter changes, not per input sample.
@JoseDiazRohena JoseDiazRohena added this to the v1.0.0 milestone Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@JoseDiazRohena