Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "Keywords added successful" with no keywords beeing shown #8

Closed
justuspfaue opened this issue Dec 1, 2022 · 7 comments
Closed
Labels
bug Something isn't working

Comments

@justuspfaue
Copy link

Hey, first of all, thanks for this awesome project!

Unluckily I have a problem where I can't add keywords. I spun up the project with the example compose and left the values as standart (on the first try i changed the key and password and so on). Then I went into the settings and added the API key for the scrapper (this works, as everytime I "add" a keyword, the count of requests on the scraper site ticks up!)

But I can neither view them in the WEBUI nor in the "api" (/api/...) in the browser (different browsers). It does show my domains, but not my keywords.

From the logs:

[1] Error: Settings file dont exist.
[1] at getAppSettings (/app/cron.js:34:16)
[0] Listening on port 3000
...
[0] GET /api/keywords?domain=DOMAINNAME
[0] getKeywords: 0
[0] SERP: KEYWORD 0
[0] ALL DONE!!!
[0] time taken: 6722.727298736572ms
[0] [Error: ENOENT: no such file or directory, open '/app/data/failed_queue.json'] {
[0] errno: -2,
[0] code: 'ENOENT',
[0] syscall: 'open',
[0] path: '/app/data/failed_queue.json'
[0] }
[0] [SUCCESS] Updating the Keyword: KEYWORD
[0] GET /api/domains
[0] GET /api/keywords?domain=DOMAINNAME
[0] getKeywords: 0

I can see the request in the browser as well as an successful answer from the backend. I am also able to see that there is in fact data in the DB (per "cat" on the server).

I hope this helps. If you need any other information, I will gladly take another look into the logs.

@towfiqi
Copy link
Owner

towfiqi commented Dec 1, 2022

@justuspfaue Sounds like the issue is actually on the frontend. Can you please check the browser console log and see if there are any errors once you submit the Add Keyword Modal?

@memarius
Copy link

memarius commented Dec 1, 2022

Hi @towfiqi,
I just installed it via docker and am encountering the same problem as op.
When looking at the browser console there are no errors.

  1. Adding Keywords: POST Request to /api/keywords comes back as 200 ok, payload looks okay too (has all the keywords and no error)
  2. In the container's log I can see that the added keywords have been successfully updated
  3. After reloading the page for the domain, the request to fetch the domains comes back as 200 with {"keywords":[]} as payload and the backend log says [0] GET /api/keywords?domain=[redacted] and [0] getKeywords: 0

@establishedweb
Copy link

Having the same issue. I've noticed that I'm only seeing these errors on domains that have "www."

@towfiqi
Copy link
Owner

towfiqi commented Dec 1, 2022

@establishedweb Thanks for that. Just spotted the bug. Will push the fix shortly.

@towfiqi towfiqi added the bug Something isn't working label Dec 1, 2022
@towfiqi towfiqi closed this as completed in 3d1c690 Dec 1, 2022
@justuspfaue
Copy link
Author

justuspfaue commented Dec 2, 2022

unluckily it does not seem to fix the whole bug for me. It now works as intended for ex. google but not for my domain which follows the pattern: XX-XX.de

It still says visually and in the log that it in fact updated the keyword, even though it does not show them/makes them accessible.

I am still getting the error for the failed queue as well as the missing settings file. I made sure to take the whole stack down (as in clean up the old image, remove the old volume and so on) and had a "clean" environment.

If you need something, hit me up. I can also send you the domain as well as the keywords if you want to replicate it.

EDIT: I also just tried it on another device, no difference here.

@towfiqi
Copy link
Owner

towfiqi commented Dec 2, 2022

@justuspfaue You are not unlucky. Its the same bug, but it occurs for domains with hyphens. Will be fixed shortly.

@justuspfaue
Copy link
Author

It's fixed now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants