Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer parallel output to prevent interleaving #1143

Closed
chrisphilip322 opened this issue Jan 17, 2019 · 3 comments
Closed

Buffer parallel output to prevent interleaving #1143

chrisphilip322 opened this issue Jan 17, 2019 · 3 comments
Labels
area:reporting feature:change something exists already but should behave differently

Comments

@chrisphilip322
Copy link

I have been using detox for a while and am happy to see parallel test running reach main tox!

It would be really nice if you could run tox in parallel mode and still get all the normal output. You can do this with the -o flag but the output is interleaved between all the processes. A different option that lets you get all the output buffered by process to prevent interleaving would be awesome. It's really convenient to have all the output available as part of a CI system so that if you need to debug something you can look at past builds to see exactly what happened.

@obestwalter obestwalter added feature:change something exists already but should behave differently area:reporting labels Jan 18, 2019
@gaborbernat
Copy link
Member

This is true. We'll move the child calls into actions after #1145, which will allow us to have the output as a log file (we can then serve on demand or just point your CI to it).

@jooon
Copy link

jooon commented Mar 6, 2019

I prefer parallel logs be printed like this: https://apenwarr.ca/log/20181106

Basically, order is already defined, same order as environment list. All output is buffered and you follow each entire buffer in order until completion. Then the first environment will be printed live and the next environments might have completed and will print fast.

Lately I've been getting back to hacking on my djb redo implementation. We've fixed some problems with file attribute handling on NFS, obsc...

@gaborbernat
Copy link
Member

In general, I'm still not convinced about the usability of parallel outputs, buffered or not. The reason we added the -o is mostly as was low cost and allows some kind of debug-ability until we implement environment output to file logging. Wouldn't it be preferable that at the end of CI you just cat the content of the log file? Easier to group things together I feel like.

@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:reporting feature:change something exists already but should behave differently
Projects
None yet
Development

No branches or pull requests

4 participants