Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CI runs to disable listing dependencies #3023

Closed
lengau opened this issue Jun 2, 2023 · 4 comments · Fixed by #3024
Closed

Allow CI runs to disable listing dependencies #3023

lengau opened this issue Jun 2, 2023 · 4 comments · Fixed by #3024

Comments

@lengau
Copy link
Contributor

lengau commented Jun 2, 2023

What's the problem this feature will solve?

Right now CI runs always list dependencies for each environment. While this is often nice, it can result in excessive output, especially when using tox to run linters and other tools.

Describe the solution you'd like

If list_dependencies_command is explicitly set as an empty string for an environment, skip the listing dependencies command.

Alternative Solutions

One alternative would be a separate configuration option for an environment to specifically disable listing dependencies.

Additional context

snapcraft and several other projects use tox to run our linters. However, when running in CI, it can be difficult to find specific linting failures between all the pip freeze lines:

image

@masenf
Copy link
Collaborator

masenf commented Jun 2, 2023

If list_dependencies_command is explicitly set as an empty string for an environment, skip the listing dependencies command.

This sounds like a good solution to me.

@gaborbernat
Copy link
Member

I'd would rather have a flag for it than ask the user to change the configuration.

@masenf
Copy link
Collaborator

masenf commented Jun 3, 2023

Fair enough. An explicit --list-dependencies / --no-list-dependencies on the cli is probably useful. I've actually exported CI=1 in non-CI runs just to get the pip freeze output.

@lengau
Copy link
Contributor Author

lengau commented Jun 3, 2023

Allowing list_dependencies_command to be empty ended up being more invasive than I expected. I've got a PR using the --list-dependencies CLI options coming as it was pretty easy to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants