Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is SHA1 the default hashing algorithm in tpm2-tools? #3340

Open
tomoveu opened this issue Jan 25, 2024 · 2 comments · May be fixed by #3342
Open

Why is SHA1 the default hashing algorithm in tpm2-tools? #3340

tomoveu opened this issue Jan 25, 2024 · 2 comments · May be fixed by #3342
Labels
Breaking Change
Milestone
6.0.0

Comments

@tomoveu
Copy link

tomoveu commented Jan 25, 2024

It looks like SHA1 is the default hashing algorithm for tpm2_hash. Could we change this to SHA256 or anything that is not deprecated?

root@9ac55cfa586b:~/lab/chapter_D# tpm2_hash -o hash.txt --hex random.bin
root@9ac55cfa586b:~/lab/chapter_D# cat hash.txt 
0d0cda9c13ececee74e8c61bf363233a906f6b84
root@9ac55cfa586b:~/lab/chapter_D# sha1sum random.bin 
0d0cda9c13ececee74e8c61bf363233a906f6b84  random.bin

where random.bin is just 64 bytes of random data as produced by tpm2_getrandom.
@tomoveu
Copy link
Author

tomoveu commented Jan 25, 2024

ping @williamcroberts @idesai

@idesai idesai added this to the 6.0.0 milestone Jan 25, 2024
@idesai idesai linked a pull request Jan 25, 2024 that will close this issue
Open
@tomoveu
Copy link
Author

tomoveu commented Feb 13, 2024

@idesai , thank you Imran

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking Change
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

tpm2_hash: Change default hashing alg from sha1 to sha256 idesai/tpm2.0-tools
2 participants
@tomoveu @idesai