-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More SOURCE_DATE_EPOCH
?
#150
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am looking into better support for "reproducible builds". I added support for
SOURCE_DATE_EPOCH
in one place in #140 - however, there are a few more timestamps in debug symbols or thestrip
command.There is already a configuration option using
ZERO_AR_DATE
which works in all these places. It replaces the timestamp with a timestamp of0
.I find
SOURCE_DATE_EPOCH
a little more elegant since it preserves a proper timestamp instead of setting it to some date in 1970. I would be happy to make the effort of enablingSOURCE_DATE_EPOCH
in all places whereZERO_AR_DATE
works right now. If we want to do it properly, we would probably change the interface / code in a few places though.I haven't fully understood the relation to upstream in this repository. Would you accept a change like this? Do you know if I could contribute this back upstream to Apple as well?
A bigger change might be to replace
fZeroModTimeInDebugMap
with a timestamp and return a timestamp inzeroModTimeInDebugMap
(or rename that function, even?).Thanks!
The text was updated successfully, but these errors were encountered: