Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show image ratios in settings #2

Open
tpow opened this issue Oct 29, 2018 · 1 comment
Open

Show image ratios in settings #2

tpow opened this issue Oct 29, 2018 · 1 comment

Comments

@tpow
Copy link
Owner

tpow commented Oct 29, 2018

It would be nice to do cropping for all images that share the same aspect ratio at once. See issue tomaszsita#50. This could be done kind of like the crop thumbnails plugin. However, unlike that plugin, I'd rather handle this on the settings side instead of including the complexity in the image editor. I would not change the current tabbed style image editor.

The first step to doing this would be to show the ratios. I'd add a new column in settings for the ratio. Ideally this would be shown like 2:1 or 4:3. (The ratio should round to the nearest whole number. This may need to be a little fuzzy -- in some themes the ratio isn't perfect, but within a pixel or so, so it'd be best to treat the ratios the same. This may be a little tricky to determine.)

Later we can add a checkbox below the list to "group by ratio" and also change the list to display them grouped somehow (or always do this by default?) Ideally this would be flexible enough to allow for some to be grouped and some not. Perhaps the group could have visibility and that could continue to be used to determine which are shown in the editor?

@ridesirat
Copy link

I don't know if this is appropriate here but I just want to congratulate you for maintaining this great plugin. I would love to help but I'm not really a developer, more a designer with respect and curiosity for your (developers) work.
I was going to suggest to put the height of the div ID="TB_window" to auto to not have to scroll down to the "crop" button but I see that in this new version is at the right side.
Very nice!
Thank you all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants