Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

設定画面スタンプタブの改修 #4141

Merged
merged 30 commits into from
Oct 21, 2024
Merged

設定画面スタンプタブの改修 #4141

merged 30 commits into from
Oct 21, 2024

Conversation

mehm8128
Copy link
Member

@mehm8128 mehm8128 commented Nov 5, 2023

プロフィールタブのPRをここから生やしてて、approveもらったタイミングで間違えてマージしちゃったので混ざってます

close #2203
close #291
close #4313

動作確認するべきこと

  • スタンプの追加ができる
    • 画像の編集も含む
  • スタンプの編集ができる
    • 名前・所有者
  • スタンプの画像更新ができる
    • 新しく選んだ画像の画像編集も含む
  • スタンプの削除ができる
  • (できれば)adminが全てのスタンプを見ることができる
  • (できれば)adminが他人のスタンプの所有者を変えることができる
  • (できれば)adminが他人のスタンプの編集や削除ができる

@mehm8128 mehm8128 self-assigned this Nov 5, 2023
Copy link

github-actions bot commented Nov 5, 2023

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.35%. Comparing base (2075787) to head (d50e32d).
Report is 145 commits behind head on master.

Current head d50e32d differs from pull request most recent head d15c500

Please upload reports for the commit d15c500 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4141      +/-   ##
==========================================
- Coverage   86.36%   86.35%   -0.01%     
==========================================
  Files          66       66              
  Lines        4722     4719       -3     
  Branches      565      564       -1     
==========================================
- Hits         4078     4075       -3     
  Misses        638      638              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mehm8128 mehm8128 marked this pull request as ready for review December 27, 2023 13:37
Copy link
Contributor

@nokhnaton nokhnaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtmです!

Copy link
Contributor

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nokhnaton さんの編集部分、改めて確認しました
大丈夫です!

@nokhnaton nokhnaton merged commit 697a1a9 into master Oct 21, 2024
9 checks passed
@nokhnaton nokhnaton deleted the feat/settings_stamp branch October 21, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants