Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add squeeze_dims function #1780

Closed
agelas opened this issue May 19, 2024 · 0 comments
Closed

Add squeeze_dims function #1780

agelas opened this issue May 19, 2024 · 0 comments

Comments

@agelas
Copy link
Contributor

agelas commented May 19, 2024

Feature description

Add a squeeze_dims function, similar to unsqueeze_dims. Specifically, this should adhere closer to the specifications in ONNX/PyTorch, which means

  1. Multiple dimensions to squeeze can be passed in as arguments
  2. Negative indices can be passed in (ie count from the back)
  3. No dimensions at all can be passed in (squeeze all singleton dimensions)

Feature motivation

This reduces friction importing from ONNX graphs and aligns burn closer to pre-existing solutions people might be used to.

@agelas agelas mentioned this issue May 19, 2024
2 tasks
@louisfd louisfd closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants