Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract common / repetitive code from instrumentations into a new common library #1997

Open
3 tasks
nirga opened this issue Sep 20, 2024 · 8 comments
Open
3 tasks
Labels
enhancement New feature or request

Comments

@nirga
Copy link
Member

nirga commented Sep 20, 2024

Which component is this bug for?

All Packages

📜 Description

Common things we have:

  • OpenTelemetry Metrics creation
  • Error reporting
  • Checking if prompt logging is allowed

Are you willing to submit PR?

None

@dosubot dosubot bot added the enhancement New feature or request label Sep 20, 2024
@ishaanagw
Copy link

Hey, can I work on this issue ?

@nirga
Copy link
Member Author

nirga commented Sep 20, 2024

Yes definitely @ishaanagw!

@ishaanagw
Copy link

Can you help me with one example of the code that is repetitive ?

@nirga
Copy link
Member Author

nirga commented Sep 20, 2024

This one for example

#1957 (comment)

@ishaanagw
Copy link

So would you want one library for all the common the common code or a different library for OpenTelemetry Metrics creation and a different one for Checking if prompt logging is allowed, and so on ?

@nirga
Copy link
Member Author

nirga commented Sep 20, 2024

One library to rule them all. Maybe we can even put it in the ai semconv library we already have

@ishaanagw
Copy link

okay, got it. Thanks

@Karush2807
Copy link

is it still open for contribution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants