Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #2072

Closed
wants to merge 1 commit into from
Closed

Update CONTRIBUTING.md #2072

wants to merge 1 commit into from

Conversation

AkashJana18
Copy link

Fixes: #2070
Updated the CONTRIBUTING.md according to guide provided in docs

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 2, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added the documentation Improvements or additions to documentation label Oct 2, 2024
@nirga
Copy link
Member

nirga commented Oct 2, 2024

Hey @AkashJana18 I don't see why we should duplicate what we have in our docs 🤔

@AkashJana18 AkashJana18 closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: General contributing guide is missing
3 participants
@AkashJana18 @CLAassistant @nirga