Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bedrock): Check if the 'result' object exists before attempting to retrieve token data #2139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(bedrock): Check if the 'result' object exists before attempting to retrieve token data #2139

wants to merge 1 commit into from

Conversation

naghost-dev
Copy link

@naghost-dev naghost-dev commented Oct 15, 2024 •
edited by nirga
Loading

Fixes #2138

  • [ x] I have added tests that cover my changes.
  • [x ] If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • [x ] PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • [x ] (If applicable) I have updated the documentation accordingly.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 15, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Miguel A. Hernandez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dosubot dosubot bot added python Pull requests that update Python code testing labels Oct 15, 2024
@naghost-dev naghost-dev mentioned this pull request Oct 15, 2024
Open
1 task
@nirga nirga changed the title fix(instrumentation): Check if the 'result' object exists before attempting to retriev… fix(instrumentation): Check if the 'result' object exists before attempting to retrieve token data Oct 15, 2024
@nirga nirga changed the title fix(instrumentation): Check if the 'result' object exists before attempting to retrieve token data fix(bedrock): Check if the 'result' object exists before attempting to retrieve token data Oct 15, 2024
nirga
nirga reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @naghost-dev! Left a small comment

...ages/opentelemetry-instrumentation-bedrock/opentelemetry/instrumentation/bedrock/__init__.py
_set_span_attribute(
span,
SpanAttributes.LLM_USAGE_TOTAL_TOKENS,
prompt_tokens + completion_tokens,
prompt_tokens + completion_tokens if completion_tokens else prompt_tokens,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead, we should guard this with an if prompt_tokens and completion tokens

@nirga
Copy link
Member

nirga commented Oct 17, 2024

@naghost-dev any plans on finishing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirga nirga nirga left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
python Pull requests that update Python code size:S This PR changes 10-29 lines, ignoring generated files. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Errors in metrics in the instrumentation of bedrock
3 participants
@naghost-dev @CLAassistant @nirga