Skip to content

Commit d35c2af

Browse files
author
Svetoslav Blyahov
committed
Update Faraday and fix failing tests/API changes
1 parent d9d7e56 commit d35c2af

File tree

39 files changed

+253
-932
lines changed

39 files changed

+253
-932
lines changed

Gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
source 'https://rubygems.org'
22

3-
gem 'faraday', '>= 0.8', '~> 0.11.0'
3+
gem 'faraday', '>= 0.8', '~> 0.14.0'
44
gem 'json'
55

66
group :test do

clever_tap.gemspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Gem::Specification.new do |spec|
2525
'public gem pushes.'
2626
end
2727

28-
spec.add_dependency 'faraday', '>= 0.8', '<= 0.11.0'
28+
spec.add_dependency 'faraday', '>= 0.8', '<= 0.14.0'
2929
spec.add_dependency 'json'
3030

3131
spec.add_development_dependency 'bundler', '~> 1.14'

spec/integrations/clever_tap_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
response = clever_tap.upload_profiles(profiles)
4646

4747
aggregate_failures do
48-
expect(response.status).to eq('fail')
48+
expect(response.status).to eq('partial')
4949
expect(response.errors).to all(be_a(Hash))
5050
expect(response.errors).to all(
5151
include('status', 'code', 'error', 'record')

spec/units/uploader_spec.rb

+1-8
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
expect(result.success?).to be_truthy
1010
expect(result.status).to eq(200)
1111
expect(body).to include('processed' => 0,
12-
'status' => 'success',
12+
'status' => 'fail',
1313
'unprocessed' => contain_exactly(
1414
a_hash_including('code' => expected_code),
1515
a_hash_including('code' => expected_code)
@@ -40,13 +40,6 @@
4040
end
4141
end
4242

43-
context 'when the gender is invalid' do
44-
let(:profiles) { [Profile.build_valid('Gender' => 'GG'), Profile.build_valid('Gender' => 'GG')] }
45-
subject { described_class.new(profiles, identity_field: 'identity') }
46-
47-
it_behaves_like 'validation failure', 514
48-
end
49-
5043
context 'when email is invalid' do
5144
let(:profiles) { [Profile.build_valid('Email' => '1234'), Profile.build_valid('Email' => '1234')] }
5245

spec/vcr_cassettes/CleverTap/uploading_a_many_profiles/when_only_some_are_valid/partial_succeed.yml

-42
This file was deleted.

spec/vcr_cassettes/CleverTap/uploading_a_many_profiles/when_only_some_are_valid/partially_succeds.yml

+16-11
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec/vcr_cassettes/CleverTap/uploading_a_profile/when_is_invalid/fail.yml

-41
This file was deleted.

spec/vcr_cassettes/CleverTap/uploading_a_profile/when_is_invalid/fails.yml

+15-10
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec/vcr_cassettes/CleverTap/uploading_a_profile/when_is_valid/succeed.yml

+6-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec/vcr_cassettes/CleverTap/uploading_an_event/when_is_valid/succeed.yml

+5-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec/vcr_cassettes/CleverTap_Client/_batched_upload/when_upload_records_are_homogenous/and_invalid_records/behaves_like_it_calls_failure_hook/calls_on_failure_upload_once.yml

-37
This file was deleted.

spec/vcr_cassettes/CleverTap_Client/_batched_upload/when_upload_records_are_homogenous/and_valid_records/and_objects_do_not_fit_upload_limit_/behaves_like_it_calls_success_hook/calls_on_successful_upload_twice.yml

-67
This file was deleted.

0 commit comments

Comments
 (0)