New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`abs_home_path`: don't warn in build or test contexts #1358

Open

smoelius opened this issue Oct 3, 2024 · 1 comment

Labels

lint

Collaborator

smoelius commented Oct 3, 2024

Such warnings tend to be false positives.

Examples where the lint is allowed:

Build context:

dylint/dylint/build.rs

Line 23 in 4438f40

#[cfg_attr(dylint_lib = "general", allow(abs_home_path))]
Test context:

dylint/cargo-dylint/tests/integration/fix.rs

Line 82 in 4438f40

#[cfg_attr(dylint_lib = "general", allow(abs_home_path))]

smoelius added the lint label

Collaborator Author

smoelius commented Nov 10, 2024

Clippy uses the crate name to detect build scripts: https://github.com/rust-lang/rust-clippy/blob/4f0e46b74dbc8441daf084b6f141a7fe414672a2/clippy_lints/src/write.rs#L293-L298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment