Add py.typed #37
Merged
Add py.typed #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you also need to add |
|
It was included in the built sdist and wheel, but I'm not sure how Poetry determines what to include by default, so I added the |
|
Thanks |
|
According to this blogpost adding the file in pyproject.toml is not necessary https://blog.whtsky.me/tech/2021/dont-forget-py.typed-for-your-typed-python-package/ |
trallnag
added a commit
that referenced
this pull request
Aug 22, 2022
Not necessary for example according to the following blogpost: https://blog.whtsky.me/tech/2021/dont-forget-py.typed-for-your-typed-python-package/ Also I tested it in another repository to make sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows mypy to use the present type annotations in packages using an installed prometheus-fastapi-instrumentator.