Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prettier-config)!: upgrade prettier to v3 #28

Merged
merged 2 commits into from
May 27, 2024
Merged

feat(prettier-config)!: upgrade prettier to v3 #28

merged 2 commits into from
May 27, 2024

Conversation

MillerSvt
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@MillerSvt MillerSvt force-pushed the prettier-v3-support branch 4 times, most recently from bb4a1d1 to 2d7322d Compare May 27, 2024 10:43
SuperOleg39
SuperOleg39 approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@SuperOleg39 SuperOleg39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperOleg39 SuperOleg39 merged commit acb4e2b into tramvaijs:main May 27, 2024
2 checks passed
@nsbarsukov nsbarsukov mentioned this pull request May 29, 2024
Merged
ereshidov
ereshidov reviewed Jun 10, 2024
View reviewed changes
packages/eslint-config/package.json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

desp -> devDeps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ereshidov ereshidov ereshidov left review comments

@SuperOleg39 SuperOleg39 SuperOleg39 approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MillerSvt @SuperOleg39 @ereshidov