Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Correctly recognize tables when the incoming schema name is not all l… #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tombriggsallego
Copy link

Problem

The schema name used to look up tables in PG is the value coming in from the stream which may be mixed case.

Proposed changes

Lower cases the schema name before retrieving the table list from PG so it matches the name created during the initial import. Fixes #70

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existing tables not found or updated correctly if incoming schema name isn't lower cased
1 participant