Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Reserved word as database name #143

Open
nugic opened this issue Feb 8, 2021 · 1 comment
Open

Reserved word as database name #143

nugic opened this issue Feb 8, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@nugic
Copy link

nugic commented Feb 8, 2021 •
edited
Loading

Describe the bug
Seems that target-snowflake doesn't allow reserved words for database (I know that it supports reserved words in table names).

To Reproduce
Steps to reproduce the behavior:

  1. Use target database name 'IN' in Snowflake.
  2. Run pipelinewise
  3. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
Executed sql by pipelinewise: SHOW COLUMNS IN SCHEMA in.qwerty
Error: SQL compilation error: syntax error line 1 at position 23 unexpected 'in'.
@nugic nugic added the bug Something isn't working label Feb 8, 2021
@nugic nugic changed the title Reserved word as schema name Reserved word as database name Feb 8, 2021
@Samira-El Samira-El added enhancement New feature or request and removed bug Something isn't working labels Feb 26, 2021
@Samira-El
Copy link
Contributor

Samira-El commented Feb 26, 2021 •
edited
Loading

Hey,
This isn't really a bug, we know that target Snowflake doesn't yet support reserved words for database names and schema names.
The fix should be straightforward: capitalize and wrap db/schema names in double quotes in queries.

We don't need this at the moment so don't think we can work on it so feel free to submit a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nugic @Samira-El