Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text or Emoji or something with upladed image Or add date on uploaded image #4229

Closed
2 tasks done
PreetamKumarjoshi opened this issue Nov 22, 2022 · 1 comment
Closed
2 tasks done
Labels

Comments

@PreetamKumarjoshi
Copy link

Initial checklist

  • I understand this is a feature request and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Problem

We can not do anything with images, We can not add any Emoji and text and markup on images

Solution

Uppy is really really excellent but some features are still missing we can not add any markup, text, or something like we can in Whatsapp

There should be a property "enable date on image" on every image so, User can see when This image was uploaded,
same as emojis or other
You can see there is no way to mark something on the image
Thanks

Alternatives

As of now, we can do one thing get the EXIF data of the image and show it at the bottom of the image thumbnail
1668750433563

@PreetamKumarjoshi PreetamKumarjoshi changed the title Add text or Emoji or something with upladed image Or bydefault add date on uploaded image Add text or Emoji or something with upladed image Or add date on uploaded image Nov 22, 2022
@Murderlon
Copy link
Member

Hi! I don't think we will do this. I'll try to explain.

  • In Uppy, we provide common use cases behind options and give primitives, such as pre and post processors and events, to let people make custom adjustments.
  • If you want something very custom, it's relatively easy to make an Uppy plugin.
  • Making a specific option for something like a date on the thumbnail is highly specific is not an agnostic way of changing something.

Hence I don't think we will do this. What I recommend is to try one of these things:

  • Use the thumbnail:generated event to customize the image afterwards. This is probably not ideal as you do double work.
  • Fork @uppy/thumbnail-generator and build it how you want. If you're using dashboard, you would have to pass disableThumbnailGenerator before adding your own with .use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants