Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/react-native dependency on expo-document-picker and expo-permissions #4248

Open
2 tasks done
seemX17 opened this issue Dec 14, 2022 · 4 comments
Open
2 tasks done
Labels

Comments

@seemX17
Copy link

seemX17 commented Dec 14, 2022

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

Install @uppy/react-native in the expo project

Expected behavior

The package should include expo permissions and a document picker or package dependencies should be mentioned in the documentation

Actual behavior

The Uppy shouldn't crash the app, if certain dependencies are missing

@Murderlon
Copy link
Member

Murderlon commented Dec 14, 2022

Hi! I think the plan is to add it to this PR: #4164 (comment)

Note that we currently don't have React Native experience on the team so we aren't maintaining it as much at the moment. We are mostly dependent on contributions, so if you want to make a PR (or help the existing one), that would be great :)

@seemX17
Copy link
Author

seemX17 commented Dec 14, 2022

Alright, thanks for the update! Will try to contribute :) More bug reports upcoming

@Murderlon
Copy link
Member

Cool! Perhaps the linked PR already solves some of your (unreported) issues.

@seemX17
Copy link
Author

seemX17 commented Dec 14, 2022

yes, it does

@arturi arturi removed the Triage label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants