Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic with adding folders toast message #4414

Closed
2 tasks done
mifi opened this issue Apr 12, 2023 · 1 comment · Fixed by #5050
Closed
2 tasks done

Fix logic with adding folders toast message #4414

mifi opened this issue Apr 12, 2023 · 1 comment · Fixed by #5050
Assignees
@lakesare
Labels
Bug

Comments

@mifi
Copy link
Contributor

mifi commented Apr 12, 2023

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

See this line:

uppy/packages/@uppy/provider-views/src/ProviderView/ProviderView.jsx

Line 304 in 00bd146

// TODO we don't really know at this point whether any files were actually added

See how to reproduce: #4402 (comment)

Expected behavior

It should not say "150 files were added" if in fact 0 files were added (due to restrictions failing)

Actual behavior

it says "150 files added but nothing gets added"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lakesare lakesare

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provider views rewrite (.files, .folders => .partialTree) transloadit/uppy
4 participants
@mifi @arturi @lakesare @Murderlon