Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/aws-s3-multipart file resume cause error - chunk null check is missing #4580

Closed
2 tasks done
SimDaeSoo opened this issue Jul 14, 2023 · 0 comments · Fixed by #4581
Closed
2 tasks done

@uppy/aws-s3-multipart file resume cause error - chunk null check is missing #4580

SimDaeSoo opened this issue Jul 14, 2023 · 0 comments · Fixed by #4581
Labels

Comments

@SimDaeSoo
Copy link

SimDaeSoo commented Jul 14, 2023

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

https://github.com/SimDaeSoo/UppyResumeErrorSample

Steps to reproduce

i'm using custom express upload server for aws s3 multipart upload.
this is my sample server & react uppy client repository.

https://github.com/SimDaeSoo/UppyResumeErrorSample

  1. first run server (yarn start) port = 3001
  2. second run react project (yarn start) port = 3000
  3. multipart upload
  4. !! when some chunk uploaded pause file upload
  5. resume
  6. error

Expected behavior

There should be no errors and the file should upload successfully.

Actual behavior

file upload resume caused error.
image

when i'm logging chunks like this code.
image

some chunk is null like this.
I don't know why some of the chunks are null, but they are.
image

So I want to modify the code to look like this
Is it okay if I create a PR?

before

chunk.setAsUploaded?.()

after

chunk?.setAsUploaded?.()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant