Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested folder selection does not work correctly #4609

Closed
2 tasks done
tcgj opened this issue Aug 4, 2023 · 2 comments · Fixed by #5050
Closed
2 tasks done

Nested folder selection does not work correctly #4609

tcgj opened this issue Aug 4, 2023 · 2 comments · Fixed by #5050
Assignees
Labels

Comments

@tcgj
Copy link
Contributor

tcgj commented Aug 4, 2023

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

Create a directory structure in OneDrive similar to this:

Folder A
| Folder B
  | File A
  1. In the uploader, tick the checkbox for Folder A.
  2. Then go into Folder A and tick the checkbox for Folder B.
  3. Click "Select"

Note:

  • I am testing this on OneDrive. The issue with selection is the same for all providers, but OneDrive displays the issue of File A being duplicated.

Expected behavior

  1. Only one file, File A, should be listed.
  2. Technically, ticking the checkbox for Folder A should automatically tick the checkbox for all of its children (i.e. if parent is selected, all child files/folders should be selected, and vice versa), so we shouldn't need to manually tick the checkbox for Folder B anyway.
  3. If only some child files/folders are selected, the parent checkbox should be indeterminate:
Screenshot 2023-08-04 at 12 53 28

Actual behavior

  1. File A is listed twice instead of once.
  2. Selecting parent folder is independent of selecting children. Selecting Folder A does not check Folder B, and allows you to select it separately.
  3. Deselecting Folder A doesn't deselect Folder B, so we can never tell which parent folders may contain selected files.
@tcgj tcgj added the Bug label Aug 4, 2023
@lakesare lakesare self-assigned this Feb 16, 2024
@lakesare
Copy link
Contributor

I can reproduce this issue, and I think your suggestions are sound - will take a look into it.

@Murderlon
Copy link
Member

Fixed in #5050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants