Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tus-js-client #4813

Closed
2 tasks done
Acconut opened this issue Dec 7, 2023 · 4 comments · Fixed by #4848
Closed
2 tasks done

Upgrade tus-js-client #4813

Acconut opened this issue Dec 7, 2023 · 4 comments · Fixed by #4848
Labels

Comments

@Acconut
Copy link
Member

Acconut commented Dec 7, 2023

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

The tus plugin and companion currently require tus-js-client@^3.0.0, which seems to be resolved to v3.0.1 when installed. However, tus-js-client v3.1.1 included an important fix to prevent tus-js-client from being stuck in a loop sending empty PATCH requests (see tus/tus-js-client#606). v3.1.2 includes a fix for progress events in Node.js, which was reported to me by you (see tus/tus-js-client#656).

Expected behavior

A newer version should be installed.

Actual behavior

An older version is installed.

@Acconut Acconut added the Bug label Dec 7, 2023
@mifi
Copy link
Contributor

mifi commented Dec 8, 2023

not sure if there's anything we need to do, because tus-js-client@^3.0.0 semver range resolves to 3.1.2 too

@Acconut
Copy link
Member Author

Acconut commented Dec 8, 2023

That's also true. I just checked and if you install companion via npm or yarn you will get a recent tus-js-client. I am just wondering why we had an old tus-js-client version in use in the api2 repo.

@mifi
Copy link
Contributor

mifi commented Dec 8, 2023

because yarn.lock file is designed to prevent packages from being updated without explicitly updating them

@Acconut
Copy link
Member Author

Acconut commented Dec 11, 2023

That makes sense, thanks for helping me understand this. I still think it would not hurt to update tus-js-client in Uppy, even though it is not absolutely necessary. But I will leave that for you to decide :) So feel free to close this if you think there is nothing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants