response data not passed to getResponseData like described when any integration e.g. Dropbox and therefor not available in uppyInstance.on('complete'

[nikgraf]

Initial checklist

• I understand this is a bug report and questions should be posted in the Community Forum
• I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

Setup Uppy companion on the client. When using any integration like Dropbox the reponse will not be properly attached to the upload-success event and therefor also not to complete.

Expected behavior

In the docs the following is stated:

When uploading files from remote providers such as Dropbox or Instagram, Companion sends upload response data to the client. This is made available in the getResponseData() function as well. The response object from Companion has some properties named after their XMLHttpRequest counterparts.

Found the particular code that results in this not being the case. There even is a TODO:

uppy/packages/@uppy/companion-client/src/RequestClient.ts

Lines 487 to 496 in 6b4f5b6

	case 'success': {
	// @ts-expect-error event expects a lot more data.
	// TODO: add missing data?
	this.uppy.emit('upload-success', file, {
	uploadURL: payload.url,
	})
	socketAbortController?.abort?.()
	resolve()
	break
	}

While not correct, because the callback not being invoked I could fix the issue by patching the node_module with:

this.uppy.emit('upload-success', file, {
  body: JSON.parse(payload.response.responseText), // new line
  uploadURL: payload.url
});

Actual behavior

The response data from the websocket should be passed to upload-success.

[orban]

Also running into similar issues, local uploads work as expected, but any integration fails as we don't get the correct callback information.

[Murderlon]

Hi, I'll take a look today