Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift-clicking works chaotically with Instagram/Unsplash #5063

Closed
2 tasks done
lakesare opened this issue Apr 9, 2024 · 2 comments · Fixed by #5050
Closed
2 tasks done

Shift-clicking works chaotically with Instagram/Unsplash #5063

lakesare opened this issue Apr 9, 2024 · 2 comments · Fixed by #5050
Assignees
Labels

Comments

@lakesare
Copy link
Contributor

lakesare commented Apr 9, 2024

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

https://uppy.io/examples

Steps to reproduce

  1. Go to Instagram/Unspash
  2. Click on one of the images
  3. Shift-click on some other image

Expected behavior

We expect it to work like it works in Google Drive e.g., all intermediate files get checked.

Actual behavior

First of all, click only happens if we click in a particular part of the image.
Secondly, SHIFT never resets, and the app always behaves as if SHIFT is pressed from then on.

@lakesare
Copy link
Contributor Author

lakesare commented May 3, 2024

#5050 fixes the issue where uppy thinks SHIFT is always pressed once it's pressed;
but doesn't fix the "SHIFT-clicking only happens if we click in a particular part of the image" issue.

I found the second issue exists in Firefox (3.35% users as per 2023 stats), however it works fine in both Chrome (64.7% users) and Safari (18.6% users) - thus making this issue not significant enough to warrant a fix (would still be nice to fix, but the fix is not trivial due to accessibility concerns!).

So we can close this issue once the 1st bug is addressed.

@Murderlon
Copy link
Member

Fixed in #5050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants