New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safeTransferFrom fails on a transfer to a BeaconProxy, but works with OZ's safeTransferFrom #370

Open

0xTimepunk opened this issue Apr 14, 2023 · 1 comment

0xTimepunk commented Apr 14, 2023

As the title implies, a safeTransferFrom using solmate's ERC20 & SafeTransferLib fails when transferring any amount to a OpenZeppelin BeaconProxy contract (https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/proxy/beacon/BeaconProxy.sol)

Using OpenZeppelins' safeTransfer library, together with their ERC20, works for the exact same call and amount.

To reproduce, just deploy a BeaconProxy attached to an implementation contract and run a safeTransferFrom in the contract.

androolloyd commented Apr 17, 2023

submit a reproduction repo plz, this is likely an issue with your setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment