New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for `testFromLast20Bytes` in `src/test/Bytes32AddressLib.t.sol` looks incorrect #395

Open

malik672 opened this issue Oct 14, 2023 · 0 comments

malik672 commented Oct 14, 2023

the test fails for

  function fromLast20Byte(bytes32 bytesValue)
        external
        pure
        returns (address _result)
    {
        assembly {
            _result := shr(
                96,
                bytesValue
            )
        }
    }

which should obviously pass, i took a look at the test and i could not understand it and it made no sense

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment