-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test cases that do not fail test (and should as indicated in test name testFailTransferFromNotAuthorized) #412
Comments
2 tasks
failure can be also reproduced by placing a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I opened this issue earlier in foundry-rs regarding an issue running solmate's tests in the benchmarks
foundry-rs/foundry#7531
yields failure because test passes
whereas if rename test to
testTransferFromNotAuthorized_counterexample
it is passingTo prevent against panics when running forge benches probably here we should not assume execution is always success but just execute
https://github.com/foundry-rs/foundry/blob/d94e3c631e2da7756af46c70f8f58b75563b7013/crates/forge/benches/test.rs#L17-L19
The
cache/fuzz/failures
cannot be found because bench clones and runs project in a temp dir which is wiped out after executionOriginally posted by @grandizzy in foundry-rs/foundry#7531 (comment)
The text was updated successfully, but these errors were encountered: