-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display [Instrumental] label on songs that are verified instrumental #36
Comments
I think we need to save a file to persist the instrumental status even after rescanning of directories. Two possible options are:
|
Could also save a .lrc with |
as of now there is no metadata tag for marking the track to be instrumental in .lrc format afaik. Since instrumental tracks have no lyrics, empty lyrics file makes logical sense. but it also needs to be discernable that the lyrics are empty on purpose and not empty because of a bug. hence some sort of metadata tag should be used to indicate that the file is empty on purpose. I suggest using the existing author tag "au" for this instead of creating a new one. e.g. metadata would be
|
@Dr-Blank It makes sense, I prefer not inventing new standards, and unconventional tag names might potentially break some faulty clients. I agree with the solution of adding an LRC file that contains If someone could make a PR for this, it would be greatly appreciated! |
Good news: it is kind of working after commit 754dd0f, though I suspect some more work needs to be done in order to release this. |
Resolved in v0.3.1 🚀 https://github.com/tranxuanthang/lrcget/releases/tag/0.3.1 |
Right now it only says [Synced] or [Plain]
The text was updated successfully, but these errors were encountered: