Skip to content

Latest commit

 

History

History
89 lines (68 loc) · 4.06 KB

README.md

File metadata and controls

89 lines (68 loc) · 4.06 KB
Raw

Firefox for iOS codebeat badge BuddyBuild codecov

Download on the App Store.

This branch (master)

This branch only works with Xcode 11 and supports iOS 11.0 and above

Please make sure you aim your pull requests in the right direction.

For bug fixes and features for a specific release use the version branch.

Getting involved

Want to contribute but don't know where to start? Here is a list of issues that are contributor friendly

Building the code

  1. Install the latest Xcode developer tools from Apple.
  2. Install Carthage 
    brew update
brew install carthage
  3. Clone the repository: 
    git clone https://github.com/mozilla-mobile/firefox-ios
  4. Pull in the project dependencies: 
    cd firefox-ios
sh ./bootstrap.sh
  5. Open Client.xcodeproj in Xcode.
  6. Build the Fennec scheme in Xcode.

Building User Scripts

User Scripts (JavaScript injected into the WKWebView) are compiled, concatenated and minified using webpack. User Scripts to be aggregated are placed in the following directories:

/Client
|-- /Frontend
    |-- /UserContent
        |-- /UserScripts
            |-- /AllFrames
            |   |-- /AtDocumentEnd
            |   |-- /AtDocumentStart
            |-- /MainFrame
                |-- /AtDocumentEnd
                |-- /AtDocumentStart

This reduces the total possible number of User Scripts down to four. The compiled output from concatenating and minifying the User Scripts placed in these folders resides in /Client/Assets and are named accordingly:

  • AllFramesAtDocumentEnd.js
  • AllFramesAtDocumentStart.js
  • MainFrameAtDocumentEnd.js
  • MainFrameAtDocumentStart.js

To simplify the build process, these compiled files are checked-in to this repository. When adding or editing User Scripts, these files can be re-compiled with webpack manually. This requires Node.js to be installed and all required npm packages can be installed by running npm install in the root directory of the project. User Scripts can be compiled by running the following npm command in the root directory of the project:

npm run build

Contributor guidelines

Creating a pull request

  • All pull requests must be associated with a specific Issue. If an issue doesn't exist please first create it.

Swift style

Whitespace

  • New code should not contain any trailing whitespace.
  • We recommend enabling both the "Automatically trim trailing whitespace" and "Including whitespace-only lines" preferences in Xcode (under Text Editing).
  • git rebase --whitespace=fix can also be used to remove whitespace from your commits before issuing a pull request.

Commits

  • Each commit should have a single clear purpose. If a commit contains multiple unrelated changes, those changes should be split into separate commits.
  • If a commit requires another commit to build properly, those commits should be squashed.
  • Follow-up commits for any review comments should be squashed. Do not include "Fixed PR comments", merge commits, or other "temporary" commits in pull requests.