Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support plugins #82

Open
trash-and-fire opened this issue Aug 21, 2023 · 11 comments · May be fixed by #84
Open

Support plugins #82

trash-and-fire opened this issue Aug 21, 2023 · 11 comments · May be fixed by #84
Assignees

Comments

@trash-and-fire
Copy link
Owner

Support plugin system.

@trash-and-fire
Copy link
Owner Author

The work on <CustomSeries> is almost done.

Peek.2023-10-08.15-24.mp4

@trash-and-fire trash-and-fire linked a pull request Oct 14, 2023 that will close this issue
@trash-and-fire
Copy link
Owner Author

I published svelte-lightweight-charts@2.3.0-rc-0 with the support of the custom series.

The example of usage you can find here

@trash-and-fire
Copy link
Owner Author

I published svelte-lightweight-charts@2.3.0-rc-1 with the support of the series primitives.

The example of usage you can find here

@trash-and-fire
Copy link
Owner Author

I'm still not sure about the final API of the new components. When implementing vertical lines, it seemed to me that we needed to add more convenience. Perhaps I will change the API in the final versions.

@oraoraroa12313
Copy link

Thanks for that, VerticalLines are exactly what I needed today.

@go-dockly
Copy link

The feature looks amazing but somehow this example does not work for me.
It can't resolve the IReactiveSeriesPrimitive dep:

    Module '"svelte-lightweight-charts"' has no exported member 'IReactiveSeriesPrimitive'


    "lightweight-charts": "^4.1.1",
    "svelte-lightweight-charts": "^2.3.0-rc-1"

besides could new VertLine(time) not be an exported member instead to not have to duplicate?

@trash-and-fire
Copy link
Owner Author

@go-dockly thanks. For some reason, a file was published without exported types. I'll publish again today when I get to the computer.

besides could new VertLine(time) not be an exported member instead to not have to duplicate?

I'm not sure I understood this phrase correctly, can you explain?

@go-dockly
Copy link

go-dockly commented Nov 26, 2023

Thanks for reply! I will try it once more :)
and I meant the Vertline example you build is such a great feature. it could be well worth being made into it's own drop-in component.
Really nice work!

@trash-and-fire
Copy link
Owner Author

trash-and-fire commented Nov 28, 2023

I published svelte-lightweight-charts@2.3.0-rc-2 with exported IReactiveSeriesPrimitive

@trash-and-fire
Copy link
Owner Author

I took the implementation of vertical lines from the repository with plugin examples: https://github.com/tradingview/lightweight-charts/tree/master/plugin-examples.

Maybe I'll make a subsection with exports of plugin components something like:

import {VerticalLine} from 'svelte-lightweight-charts/plugins/vertical-line';

@skedzior
Copy link

super thankful for your work here, i was just about to attempt to implement it myself before checking here <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants