Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pages provider assumes complete control over pages repository #1164

Closed
adrianbroher opened this issue Feb 16, 2020 · 4 comments
Closed

pages provider assumes complete control over pages repository #1164

adrianbroher opened this issue Feb 16, 2020 · 4 comments
Labels

Comments

@adrianbroher
Copy link

adrianbroher commented Feb 16, 2020

The copy task of the Github pages provider currently copies the local_dir contents into the root of the checked out git repository.

However this prevents me from generating only a subdirectory of the Github pages. This can be useful to use the root for the project homepage and placing the API inside a subdirectory, maybe even separated by branch or tag name.

I would like to see a new target_dir parameter, which allows to select the target directory, where the copy task should place the files into. By default this could point to ., the root of the Github pages repository.

I would like to provide a PR if the idea is generally accepted.

@adrianbroher adrianbroher changed the title pages provides assumes complete control over pages directory pages provider assumes complete control over pages repository Feb 16, 2020
@svenfuchs
Copy link
Contributor

@adrianbroher i think this totally makes sense. would be happy to accept your PR!

@stale
Copy link

stale bot commented May 16, 2020

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues

@stale stale bot added the stale label May 16, 2020
@adrianbroher
Copy link
Author

Issue still persists.

@stale stale bot removed the stale label May 16, 2020
@stale
Copy link

stale bot commented Aug 16, 2020

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues

@stale stale bot added the stale label Aug 16, 2020
@stale stale bot closed this as completed Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants