Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.9 is released. Seems like don't support 1.9 stable build. #107

Closed
easonlin404 opened this issue Aug 25, 2017 · 3 comments
Closed

Go 1.9 is released. Seems like don't support 1.9 stable build. #107

easonlin404 opened this issue Aug 25, 2017 · 3 comments

Comments

@easonlin404
Copy link

easonlin404 commented Aug 25, 2017

I add - 1.9.x in my travis.yml And I got following message:

$ GIMME_OUTPUT=$(gimme 1.9.x | tee -a $HOME/.bashrc) && eval "$GIMME_OUTPUT"
I don't have any idea what to do with '1.9.x'.

Please help to figure out. Thanks.

@easonlin404 easonlin404 changed the title Go 1.9 release. Please add 1.9 stable build. Go 1.9 is released. Please add 1.9 stable build. Aug 25, 2017
@philpennock
Copy link
Contributor

philpennock commented Aug 25, 2017

Opinion as an outside contributor to the gimme repo only: it's fair for people to file bugs like this against gimme, because it looks like gimme at fault, even though the .x mapping is entirely managed in the travis-build repo at a layer above gimme. People not closely involved shouldn't need to know that.

However, should we be doing more inside gimme? Perhaps handling .x cleanly, or perhaps just saying "hey, we don't support .x handling here, something has failed to detect this before passing it to us", to give a more useful diagnostic?

EDITED TO ADD: have opened #110 to discuss this

@easonlin404
Copy link
Author

@philpennock My apologies. I didn't awareness this. Sorry again. 😢

@easonlin404 easonlin404 changed the title Go 1.9 is released. Please add 1.9 stable build. Go 1.9 is released. Seems like don't support 1.9 stable build. Aug 26, 2017
@philpennock
Copy link
Contributor

No apologies; it was completely reasonable. #110 filed to better support folks in this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants