Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: support specifying a commit ref instead of master #143

Closed
myitcv opened this issue May 2, 2018 · 6 comments
Closed

proposal: support specifying a commit ref instead of master #143

myitcv opened this issue May 2, 2018 · 6 comments

Comments

@myitcv
Copy link

myitcv commented May 2, 2018

Have the ability to build go tip is great, but building against the current master commit is not particularly useful because that's a moving feast.

Instead it would be useful to be able to specify (in .travis.yml files) a specific commit.

@philpennock
Copy link
Contributor

This is supported in master already, will be part of the upcoming 1.5.0 release, whenever Travis decides to cut that.

@philpennock
Copy link
Contributor

% eval "$(./gimme 0dcdbc772e62)"
go version devel +0dcdbc772e Wed May 2 17:36:17 2018 +0000 darwin/amd64
%

@myitcv
Copy link
Author

myitcv commented May 2, 2018

Thanks @philpennock - look forward to this landing in Travis.

@myitcv
Copy link
Author

myitcv commented May 28, 2018

Quick question: will this effectively pull a cached build, or will it rebuild from commit X each time?

@philpennock
Copy link
Contributor

gimme only pulls builds when doing binary installs. Gimme will locally cache builds but has no distributed caching support. We do not currently support re-using a cached build of a git revision, here's the comment I wrote at the time:

# We do _not_ try to use any version caching with _try_existing(), but instead
# build afresh each time.  We don't want to deal with someone moving the repo
# to other-version, doing an install, then resetting it back to
# last-version-we-saw and thus introducing conflicts.
#
# If you want to re-use a built-at-spec version, then avoid moving the repo
# and source the generated .env manually.
# Note that the env will just refer to the 'go' directory, so it's not safe
# to reuse anyway.

We use one common directory ~/.gimme/versions/go for all these builds and there's no way to guarantee the status. There are things we can do to improve this, but we don't have them yet.

@philpennock
Copy link
Contributor

Filed issue #147 to ask for feedback on level of interest in reusable revision-specific builds, and propose one solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants