Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests/CI fail with CRLF line endings #164

Closed
lukedan opened this issue Feb 25, 2021 · 2 comments · Fixed by #188
Closed

Tests/CI fail with CRLF line endings #164

lukedan opened this issue Feb 25, 2021 · 2 comments · Fixed by #188

Comments

@lukedan
Copy link

lukedan commented Feb 25, 2021

The following tests fail for CRLF line endings:

  • corpus - declarations - unparenthesized call as superclass
  • corpus - expressions - method call with line break
  • corpus - expressions - backslash-newline as line continuation
  • corpus - literals - newline-delimited strings
  • ruby_errors - Heredocs with errors

See also tree-sitter/tree-sitter#913
@maxbrunsfeld
Copy link
Contributor

Thanks for the report!

@patrickt
Copy link
Contributor

patrickt commented Mar 9, 2021

This is causing the Windows builds on #166 to fail; once we fix that, we should reenable them.

@patrickt patrickt changed the title Tests fail with CRLF line endings Tests/CI fail with CRLF line endings Mar 9, 2021
This was referenced Sep 25, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed CRLF behavior for tests
3 participants
@patrickt @maxbrunsfeld @lukedan