Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] By default include POI's into generated maps #151

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Sep 26, 2022

This PR…

  • introduces the tag-wahoo .xml file for including POI's as default

Considerations and implementations

As most of the people use wahooMapsCreator to create maps including POI's, this is now golden standard.

How to test

  1. python -m wahoomc cli -co malta
  2. check if created maps have POI's included

Pull Request Checklist

@treee111 treee111 added the enhancement New feature or request label Sep 26, 2022
@treee111 treee111 added this to the v2.1.0 milestone Sep 26, 2022
@treee111 treee111 force-pushed the default-poi-wahoo-tag-xml branch from 850f20c to ddf7178 Compare October 2, 2022 18:27
@treee111 treee111 changed the title [FEAT] Include POIs into generated maps as default [BREAKING] Include POIs into generated maps as default Oct 2, 2022
@treee111 treee111 changed the title [BREAKING] Include POIs into generated maps as default [BREAKING] Include POIs into generated maps by default Oct 3, 2022
@treee111 treee111 changed the title [BREAKING] Include POIs into generated maps by default [BREAKING] Include POI's into generated maps by default Oct 3, 2022
@treee111 treee111 force-pushed the default-poi-wahoo-tag-xml branch from ddf7178 to 2723f37 Compare October 3, 2022 19:02
@treee111 treee111 changed the title [BREAKING] Include POI's into generated maps by default [BREAKING] By default include POI's into generated maps Oct 3, 2022
@treee111 treee111 merged commit 15b9e26 into develop Oct 3, 2022
@treee111 treee111 deleted the default-poi-wahoo-tag-xml branch October 3, 2022 19:41
treee111 added a commit that referenced this pull request Nov 12, 2022
treee111 added a commit that referenced this pull request Nov 12, 2022
is default since #151
delete dublicated and not needed launch configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant