Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Do not use geofabrik .json file before geofabrik .json file has been downloaded #192

Merged
merged 3 commits into from
Apr 1, 2023
Merged

[BUGFIX] Do not use geofabrik .json file before geofabrik .json file has been downloaded #192

merged 3 commits into from
Apr 1, 2023

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Apr 1, 2023 •
edited
Loading

This PR…

  • changes usages of the geofabrik .json file to not use the file during .py file initialization
  • downloads the geofabrik .json at the beginning with all tooling stuff
  • check if the geofabrik .json file is downloaded

Considerations and implementations

screenshot of the error:
grafik

How to test

  1. delete geofabrik.json file manually /Users/<USERNAME>/wahooMapsCreatorData/_download/geofabrik.json
  2. python -m wahoomc cli -h or python -m wahoomc gui
  3. it should work as normally

Pull Request Checklist

@treee111 treee111 added the bug Something isn't working label Apr 1, 2023
@treee111 treee111 changed the base branch from develop to release-v4.0.0 April 1, 2023 20:59
@treee111 treee111 changed the title [BUGFIX] Do not use geofabrik .json file before geofabrik .json file is downloaded [BUGFIX] Do not use geofabrik .json file before geofabrik .json file has been downloaded Apr 1, 2023
@treee111 treee111 merged commit badef50 into release-v4.0.0 Apr 1, 2023
@treee111 treee111 deleted the bugfix-geofabrik-dl branch April 1, 2023 21:03
treee111 added a commit that referenced this pull request May 5, 2023
@treee111
[BUGFIX] Do not use geofabrik .json file before geofabrik .json file …
f27800b 
…has been downloaded (#192)

* remove non-instance o_geofabrik_json objects

* dl geofabrik independent of Downloader object

- handle geofabrik file firstly as tooling, later on with -md

* unify constructors
alfh pushed a commit to alfh/wahooMapsCreator that referenced this pull request Nov 4, 2023
@treee111 @alfh
[BUGFIX] Do not use geofabrik .json file before geofabrik .json file …
3e15c0d 
…has been downloaded (treee111#192)

* remove non-instance o_geofabrik_json objects

* dl geofabrik independent of Downloader object

- handle geofabrik file firstly as tooling, later on with -md

* unify constructors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@treee111