Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] install shapely and requests via conda instead of pip. For processing geofabrik.json with shapely on Windows #193

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Apr 2, 2023

This PR…

  • does install shapely and requests in the initial creation of the Anaconda environment instead of installing via pip when wahoomc is installed

wahoomc crashes silently when geofabrik file is calculated in this line. The problem seams to be shapely.
grafik

Considerations and implementations

This situation was already present in all versions which have the option to calculate tiles via geofabrik .json instead of static .json files (i.e. since version 0.11.0).
Because geofabrik processing is the standard and only processing mode, it came up just now

see faq and issue 1105

How to test

  1. create Acaconda environment with
conda create -n gdal-user python=3.10 geojson=2.5 gdal=3.4 requests=2.28 shapely=1.8 pip --channel conda-forge --override-channels
  1. run wahoomc for a country of your choice

Pull Request Checklist

Screenshots

When shapely is installed via pip
grafik

this error was already existing in v3.2.0:
grafik

and as well in the alpha versions of v4.0.0. v4.0.0a5:
grafik

installing shapely via conda
grafik

works for v3.2.0:
grafik

and alpha versions of v4.0.0. v4.0.0a5:
grafik

without that, geofabrik processing, namely shapely does not work in Windows
@treee111 treee111 force-pushed the install-shapely-in-conda branch from 068c7b1 to fb0fe17 Compare April 2, 2023 17:14
@treee111 treee111 changed the title Install shapely in conda [BUGFIX] install shapely and requests via conda instead of pip Apr 2, 2023
@treee111 treee111 added bug Something isn't working infrastructure Infrastructure labels Apr 2, 2023
@treee111 treee111 changed the base branch from develop to release-v4.0.0 April 2, 2023 17:27
@treee111 treee111 marked this pull request as ready for review April 2, 2023 17:27
@treee111 treee111 changed the title [BUGFIX] install shapely and requests via conda instead of pip [BUGFIX] install shapely and requests via conda instead of pip. For processing geofabrik.json with shapely Apr 2, 2023
@treee111 treee111 changed the title [BUGFIX] install shapely and requests via conda instead of pip. For processing geofabrik.json with shapely [BUGFIX] install shapely and requests via conda instead of pip. For processing geofabrik.json with shapely on Windows Apr 2, 2023
@treee111 treee111 merged commit c84c3e0 into release-v4.0.0 Apr 2, 2023
@treee111 treee111 deleted the install-shapely-in-conda branch April 2, 2023 17:41
treee111 added a commit that referenced this pull request May 5, 2023
…rocessing geofabrik.json with shapely on Windows (#193)

install shapely and requests via conda instead of pip. For geofabrik

without that, geofabrik processing, namely shapely does not work in Windows
alfh pushed a commit to alfh/wahooMapsCreator that referenced this pull request Nov 4, 2023
…rocessing geofabrik.json with shapely on Windows (treee111#193)

install shapely and requests via conda instead of pip. For geofabrik

without that, geofabrik processing, namely shapely does not work in Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant