[BUGFIX] install shapely and requests via conda instead of pip. For processing geofabrik.json with shapely on Windows #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR…
wahoomc crashes silently when geofabrik file is calculated in this line. The problem seams to be shapely.
![grafik](https://user-images.githubusercontent.com/53038537/229368840-f974d7bd-f89b-4f2a-84d2-698f1746c638.png)
Considerations and implementations
This situation was already present in all versions which have the option to calculate tiles via geofabrik .json instead of static .json files (i.e. since version 0.11.0).
Because geofabrik processing is the standard and only processing mode, it came up just now
see faq and issue 1105
How to test
Pull Request Checklist
Screenshots
When shapely is installed via pip
![grafik](https://user-images.githubusercontent.com/53038537/229367637-dd216218-d059-420a-8119-482b8319b871.png)
this error was already existing in v3.2.0:
![grafik](https://user-images.githubusercontent.com/53038537/229367772-6155de02-4474-499e-bf9f-573e1b2710e4.png)
and as well in the alpha versions of v4.0.0. v4.0.0a5:
![grafik](https://user-images.githubusercontent.com/53038537/229367847-4a21a6f8-6b15-4046-bf38-e34704e2bf87.png)
installing shapely via conda
![grafik](https://user-images.githubusercontent.com/53038537/229367657-14e6340f-e0e4-4e63-a34a-311e8afdd41b.png)
works for v3.2.0:
![grafik](https://user-images.githubusercontent.com/53038537/229368144-021e1f80-80fa-4128-8860-208450c7fefe.png)
and alpha versions of v4.0.0. v4.0.0a5:
![grafik](https://user-images.githubusercontent.com/53038537/229367822-05612e20-2bfa-4cee-bb37-9669d0ce914b.png)