[FEATURE] Performance improvement for .osm.pbf creation and splitting. Use 'v12' tag (keep) filters #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- now not only for GUI but also for CLI the country argument is checked - added a check at the start to see if a country is to process is specified. Otherwise closing the GUI without selecting anything resulted in a runtime error.
…d .osm.pbf files (#43) - use the files modification date, not the creation time. On windows this seemed to occasionally see newly downloaded files as the ones they replaced. - check for a full match instead of doing a wildcard match while checking for existing maps. This prevents matching to multiple maps like australia and australia-oceania.
- change pylint findings - format constans on save - delete unused comments
treee111
changed the title
Ebe66
approved these changes
Oct 22, 2021
This was referenced Oct 22, 2021
treee111
added a commit
that referenced
this pull request
Oct 22, 2021
…arge countries (#47) - Changes how the resulting tiles.zip and maps.zip file is made. Now files are copied from the 'tilestore' to a country-name and country-name-maps folder. This folder is then passed to the compressor instead of building an enormous command line with all file names specified. This would, for large countries like Russia, result in errors because the command line was to long. - Added advantage: Optionally you can choose via CLI to keep these folders so you can instantly copy the files to your device or check them in Cruiser. - Copies the - currently static numbered - tile-present/version files (created in #46) to the tiles.zip archive * change zipping map and cruiser files - 7za / zip commands with other arguments - filling the "new" country-maps folder * Introduce option to keep folders - keep or delete the country/region map folders after compression - available via CLI argument * refactoring / code cleanup - delete & unify comments - make variables setting less redundant - introduce types for except * delete empty line creations caused by rebase
This was referenced Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR…
This PR is extracted from #40 and delivers the following functionalities: