You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I decided to add this package on playground (PMunch/nim-playground#7), but because maximum execution time is capped at 20s it might be possible for the benchmark to be terminated externally without even finishing.
I know that 60s cap is not always reached, but considering playground has relatively low execution power it might happen more often compared to regular use.
at least 10 times but possibly more to figure out the standard deviation. It will keep running it until things look like they stabilized. It will stop after 60s though.
I thought about adding cappedTimeIt(maxSeconds: int, name: string, body: untyped) that would allow configuring maximum running time. Make timeIt an alias for cappedTimeIt(60, ...)
Does the implementation idea sound good, or you would prefer to keep this package as simple as possible, without any configuration complexity?
The text was updated successfully, but these errors were encountered:
Sorry I don't understand you want it to be infinite? or 20seconds?
Just as the title says - I want to be configurable. I didn't know you can pass the maximum number of iterations (it is not mentioned in README, and I didn't look into tests (although I should've done this before opening an issue)). I think that solves an issue, though an option to have "another param that passes max time too." would be exactly what I need in this case.
The time cap is there really as a fail safe. Most benches should finish in 1-5s seconds. No one has time to wait a full minute!
Yes, of course, but in PMunch/nim-playground#7 PMunch was concerned with the possibility of the benchmark executing for longer than twenty seconds.
I decided to add this package on playground (PMunch/nim-playground#7), but because maximum execution time is capped at 20s it might be possible for the benchmark to be terminated externally without even finishing.
I know that 60s cap is not always reached, but considering playground has relatively low execution power it might happen more often compared to regular use.
I thought about adding
cappedTimeIt(maxSeconds: int, name: string, body: untyped)
that would allow configuring maximum running time. MaketimeIt
an alias forcappedTimeIt(60, ...)
Does the implementation idea sound good, or you would prefer to keep this package as simple as possible, without any configuration complexity?
The text was updated successfully, but these errors were encountered: