Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fidget breaks nim CI again #133

Closed
timotheecour opened this issue Jan 27, 2021 · 7 comments
Closed

fidget breaks nim CI again #133

timotheecour opened this issue Jan 27, 2021 · 7 comments

Comments

@timotheecour
Copy link

timotheecour commented Jan 27, 2021

(previous instances: #121 + other more recent IIRC)

as mentioned in #121 (comment), it would be good to find and fix root cause for such regressions;

EDIT: looks like it's guzba/nimsimd@538c47f#r46409625

logs

FAIL: fidget c
https://github.com/nim-lang/Nim/pull/16831/checks?check_run_id=1775941555

Compiling /Users/runner/work/Nim/Nim/pkgstemp/fidget/tests/test (from package fidget) using c backend
/Users/runner/.nimble/pkgs/pixie-0.0.16/pixie/images.nim(182, 30) Error: type mismatch: got <int literal(255)>
but expected one of:
func mm_set1_epi8(a: int8): M128i
first type mismatch at position: 1
required type for a: int8
but expression '255' is of type: int literal(255)

expression: mm_set1_epi8(255)
Tip: 73 messages have been suppressed, use --verbose to show them.
Error: Execution failed with exit code 256
... Command: /Users/runner/work/Nim/Nim/bin/nim c --noNimblePath -d:NimblePkgVersion=0.7.1 --path:/Users/runner/.nimble/pkgs/chroma-0.2.1 --path:/Users/runner/.nimble/pkgs/typography-0.7.4 --path:/Users/runner/.nimble/pkgs/pixie-0.0.16 --path:/Users/runner/.nimble/pkgs/vmath-0.4.1 --path:/Users/runner/.nimble/pkgs/chroma-0.2.1 --path:/Users/runner/.nimble/pkgs/zippy-0.5.2 --path:/Users/runner/.nimble/pkgs/flatty-0.1.5 --path:/Users/runner/.nimble/pkgs/nimsimd-1.0.0 --path:/Users/runner/.nimble/pkgs/bumpy-1.0.1 --path:/Users/runner/.nimble/pkgs/vmath-0.4.1 --path:/Users/runner/.nimble/pkgs/vmath-0.4.1 --path:/Users/runner/.nimble/pkgs/chroma-0.2.1 --path:/Users/runner/.nimble/pkgs/print-0.2.0 --path:/Users/runner/.nimble/pkgs/bumpy-1.0.1 --path:/Users/runner/.nimble/pkgs/vmath-0.4.1 --path:/Users/runner/.nimble/pkgs/flatty-0.1.5 --path:/Users/runner/.nimble/pkgs/pixie-0.0.16 --path:/Users/runner/.nimble/pkgs/vmath-0.4.1 --path:/Users/runner/.nimble/pkgs/chroma-0.2.1 --path:/Users/runner/.nimble/pkgs/zippy-0.5.2 --path:/Users/runner/.nimble/pkgs/flatty-0.1.5 --path:/Users/runner/.nimble/pkgs/nimsimd-1.0.0 --path:/Users/runner/.nimble/pkgs/bumpy-1.0.1 --path:/Users/runner/.nimble/pkgs/vmath-0.4.1 --path:/Users/runner/.nimble/pkgs/vmath-0.4.1 --path:/Users/runner/.nimble/pkgs/print-0.2.0 --path:/Users/runner/.nimble/pkgs/opengl-1.2.6 --path:/Users/runner/.nimble/pkgs/x11-1.1 --path:/Users/runner/.nimble/pkgs/html5_canvas-1.3 --path:/Users/runner/.nimble/pkgs/staticglfw-4.1.2 --path:/Users/runner/.nimble/pkgs/opengl-1.2.6 --path:/Users/runner/.nimble/pkgs/x11-1.1 --path:/Users/runner/.nimble/pkgs/cligen-1.4.0 --path:/Users/runner/.nimble/pkgs/supersnappy-2.0.0 --path:/Users/runner/.nimble/pkgs/bumpy-1.0.1 --path:/Users/runner/.nimble/pkgs/vmath-0.4.1 --hints:off -r --path:. /Users/runner/work/Nim/Nim/pkgstemp/fidget/tests/test

@guzba
Copy link
Contributor

guzba commented Jan 27, 2021

This is resolved, reran on my fork, is green. https://github.com/guzba/fidget/runs/1779879598

@timotheecour
Copy link
Author

timotheecour commented Jan 29, 2021

@guzba can you make a PR to revert nim-lang/Nim#16842 and close this issue if it's fixed?

@narimiran
Copy link

This is resolved

Doesn't seem like it is — it still fails on Nim 1.4.x CIs, for example: https://github.com/nim-lang/Nim/runs/1856156288#step:11:602

@treeform
Copy link
Owner

I really like including fidget as an important nim repo that Nim compiler tests against. It makes me proud of the work we have done.

Yet, we are working a ton on Fidget/Pixie/Typography. Maybe its best to keep it out of the CI for now, until we are more done with the project?

Feel free to reopen if you disagree.

@timotheecour
Copy link
Author

timotheecour commented Feb 28, 2021

Maybe its best to keep it out of the CI for now, until we are more done with the project?

how about:

  • make sure important_packages keeps testing fidget, but at latest release tag, not HEAD:
# pkg1 "fidget" # pending https://github.com/treeform/fidget/issues/133

=>

pkg1 "fidget", useHead = false
  • then fidget can keep being developped, and CI won't break latest release tag

furthermore, we can also add support for this in imporant_packages:

pkg1 "fidget", hash = 0.1.3 # or any other hash starting with a #
in case some packages (eg fidget) needs to have unstable release tags (eg odd numbers)

@narimiran
Copy link

pkg1 "fidget", useHead = false

I'm now adding this, together with adding pixie.

furthermore, we can also add support for this in imporant_packages:
pkg1 "fidget", hash = 0.1.3 # or any other hash starting with a #

Pass.

@timotheecour
Copy link
Author

@treeform
see logs for nim-lang/Nim#17229 with useHead=false:

       Error: Cannot satisfy the dependency on chroma 0.2.4 and chroma 0.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants