Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded get verb in $ proc #44

Closed
srozb opened this issue Nov 18, 2021 · 1 comment · Fixed by #45
Closed

Hardcoded get verb in $ proc #44

srozb opened this issue Nov 18, 2021 · 1 comment · Fixed by #45

Comments

@srozb
Copy link
Contributor

srozb commented Nov 18, 2021

Hi,
I think echoing Request will always show the verb being get no matter what verb actually is used. See this line.

This is very confusing. Would also be very helpful to print post body if defined.
@srozb srozb mentioned this issue Nov 18, 2021
Merged
@guzba
Copy link
Collaborator

guzba commented Nov 19, 2021

Sorry for the hardcoded value. That was an oversight on our part. Thanks for the PR and test to fix this.

@guzba guzba closed this as completed in #45 Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Request striginfy fix
2 participants
@guzba @srozb